Review Request 125091: Speedup finding the property change signals

Sebastian Kügler sebas at kde.org
Mon Sep 7 21:13:48 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125091/#review84978
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On Sept. 7, 2015, 2:05 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125091/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 2:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> We collected those signals in the constructor (initRoleNames) already,
> so no need to iterate above them again. We can get the propertyChanged
> Meta Method directly by it's name, we don't need to loop there either.
> 
> 
> Diffs
> -----
> 
>   src/pulseaudio.cpp 911088aab10dcc76208b7c36eaa60ab9b79298ad 
> 
> Diff: https://git.reviewboard.kde.org/r/125091/diff/
> 
> 
> Testing
> -------
> 
> Everything works as before.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150907/ac69e766/attachment.html>


More information about the Plasma-devel mailing list