Review Request 125073: Support dropping windows onto the pager

Kai Uwe Broulik kde at privat.broulik.de
Sun Sep 6 18:52:21 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125073/
-----------------------------------------------------------

(Updated Sept. 6, 2015, 6:52 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Changes
-------

Submitted with commit b80bd0f74e12241458dba3f366b4c7e6c051f0cc by Kai Uwe Broulik to branch Plasma/5.4.


Bugs: 352349
    https://bugs.kde.org/show_bug.cgi?id=352349


Repository: plasma-desktop


Description
-------

The method is called from QML but was never actually implemented.

Also add preventStealing so hovering the pager won't cause the panel to make room for a drop shifting the pager around


Diffs
-----

  applets/pager/plugin/pager.h 83626a5 
  applets/pager/plugin/pager.cpp 3119ef0 
  applets/pager/package/contents/ui/main.qml 2ecdf8f 

Diff: https://git.reviewboard.kde.org/r/125073/diff/


Testing
-------

Works. The other code has checks for X11 but shouldn't KWindowSystem work (or at least not crash) regardless of windowing system?


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150906/c7bf0c37/attachment.html>


More information about the Plasma-devel mailing list