Review Request 125073: Support dropping windows onto the pager

Marco Martin notmart at gmail.com
Sun Sep 6 18:40:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125073/#review84906
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Sept. 6, 2015, 2:36 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125073/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2015, 2:36 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 352349
>     https://bugs.kde.org/show_bug.cgi?id=352349
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The method is called from QML but was never actually implemented.
> 
> Also add preventStealing so hovering the pager won't cause the panel to make room for a drop shifting the pager around
> 
> 
> Diffs
> -----
> 
>   applets/pager/plugin/pager.h 83626a5 
>   applets/pager/plugin/pager.cpp 3119ef0 
>   applets/pager/package/contents/ui/main.qml 2ecdf8f 
> 
> Diff: https://git.reviewboard.kde.org/r/125073/diff/
> 
> 
> Testing
> -------
> 
> Works. The other code has checks for X11 but shouldn't KWindowSystem work (or at least not crash) regardless of windowing system?
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150906/fd4dd632/attachment.html>


More information about the Plasma-devel mailing list