Review Request 125026: Wayland implementation for DPMS

Martin Gräßlin mgraesslin at kde.org
Wed Sep 2 07:12:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125026/
-----------------------------------------------------------

Review request for Plasma, Solid and Kai Uwe Broulik.


Repository: powerdevil


Description
-------

An AbstractDpmsHelper is introduced with a concrete subclass called
XcbDpmsHelper. The PowerDevilDpmsAction holds a helper and delegates
to it. The XcbDpmsHelper implements the X11 specific tasks. This will
allow to add a Wayland implementation as well.

[dpms] Add a Wayland implementation

The Wayland implementation uses the DpmsManager provided by KWayland.
On a timeout it turns the screens off and it supports the trigger
modes. The fade helper is not supported (yet) as it is an X11 only
implementation.


Diffs
-----

  CMakeLists.txt 457f74a318588690c3b9890a5bfdb0a4ea887042 
  daemon/actions/dpms/CMakeLists.txt 61d7b5684f85c29081dc863abbffa42898089d2a 
  daemon/actions/dpms/abstractdpmshelper.h PRE-CREATION 
  daemon/actions/dpms/abstractdpmshelper.cpp PRE-CREATION 
  daemon/actions/dpms/powerdevildpmsaction.cpp ac824787d5907e78ce0f3ede0e822ffbc778cb3c 
  daemon/actions/dpms/powerdevildpmsaction.desktop 85ec8619bab9da70fddee4d8815ebdb8899000cd 
  daemon/actions/dpms/powerdevildpmsaction.h d8b92784abc3717487050928c04c6022480cbd49 
  daemon/actions/dpms/waylanddpmshelper.h PRE-CREATION 
  daemon/actions/dpms/waylanddpmshelper.cpp PRE-CREATION 
  daemon/actions/dpms/xcbdpmshelper.h PRE-CREATION 
  daemon/actions/dpms/xcbdpmshelper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125026/diff/


Testing
-------

How I tested:
* run kwin_wayland on a DRM device
* started kded5
* configured powerdevil to suspend after one minute
* waited
* watched screen go off
* enabled again, looked at debug output to verify it was triggered by powerdevil.
 
It's currently only tested with Qt 5.4. At least for idle integration I had the problem that things somehow stopped working with 5.5. So this needs additional testing.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150902/15e08341/attachment-0001.html>


More information about the Plasma-devel mailing list