<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125026/">https://git.reviewboard.kde.org/r/125026/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Solid and Kai Uwe Broulik.</div>
<div>By Martin Gräßlin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">An AbstractDpmsHelper is introduced with a concrete subclass called
XcbDpmsHelper. The PowerDevilDpmsAction holds a helper and delegates
to it. The XcbDpmsHelper implements the X11 specific tasks. This will
allow to add a Wayland implementation as well.
[dpms] Add a Wayland implementation
The Wayland implementation uses the DpmsManager provided by KWayland.
On a timeout it turns the screens off and it supports the trigger
modes. The fade helper is not supported (yet) as it is an X11 only
implementation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How I tested:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> run kwin_wayland on a DRM device
</em> started kded5
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> configured powerdevil to suspend after one minute
</em> waited
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> watched screen go off
</em> enabled again, looked at debug output to verify it was triggered by powerdevil.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's currently only tested with Qt 5.4. At least for idle integration I had the problem that things somehow stopped working with 5.5. So this needs additional testing.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(457f74a318588690c3b9890a5bfdb0a4ea887042)</span></li>
<li>daemon/actions/dpms/CMakeLists.txt <span style="color: grey">(61d7b5684f85c29081dc863abbffa42898089d2a)</span></li>
<li>daemon/actions/dpms/abstractdpmshelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/dpms/abstractdpmshelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/dpms/powerdevildpmsaction.cpp <span style="color: grey">(ac824787d5907e78ce0f3ede0e822ffbc778cb3c)</span></li>
<li>daemon/actions/dpms/powerdevildpmsaction.desktop <span style="color: grey">(85ec8619bab9da70fddee4d8815ebdb8899000cd)</span></li>
<li>daemon/actions/dpms/powerdevildpmsaction.h <span style="color: grey">(d8b92784abc3717487050928c04c6022480cbd49)</span></li>
<li>daemon/actions/dpms/waylanddpmshelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/dpms/waylanddpmshelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/dpms/xcbdpmshelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/dpms/xcbdpmshelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125026/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>