Review Request 125023: Fix initialization of the DesktopView on Qt 5.6

[Aleix Pol Gonzalez]

> On Sept. 1, 2015, 6:40 p.m., David Edmundson wrote:
> > >setSource is changing the current screen
> > 
> > Any idea why?

Every setGeometry computes the screen. It can change almost anywhere.


> On Sept. 1, 2015, 6:40 p.m., David Edmundson wrote:
> > shell/desktopview.cpp, line 53
> > <https://git.reviewboard.kde.org/r/125023/diff/1/?file=400005#file400005line53>
> >
> >     this happens in adaptToScreen which we always call below
> >     
> >     either it's not needed or we have another problem

I see your point. I'm unsure why that happens.
Let's just hold the patch for now until I better understand what's going on.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125023/#review84714
-----------------------------------------------------------


On Sept. 1, 2015, 6:32 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125023/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 6:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> setSource is changing the current screen, so ensure we're putting the view where it belongs.
> Otherwise it gets in a ping pong cycle between both screens.
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.cpp 8e20d44 
> 
> Diff: https://git.reviewboard.kde.org/r/125023/diff/
> 
> 
> Testing
> -------
> 
> Now I can boot it (on my devel user, my normal user crashes for some reason, see further e-mail)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150901/d9c7c913/attachment.html>