Review Request 125023: Fix initialization of the DesktopView on Qt 5.6
David Edmundson
david at davidedmundson.co.uk
Tue Sep 1 16:40:25 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125023/#review84714
-----------------------------------------------------------
>setSource is changing the current screen
Any idea why?
shell/desktopview.cpp (line 49)
<https://git.reviewboard.kde.org/r/125023/#comment58631>
this happens in adaptToScreen which we always call below
either it's not needed or we have another problem
- David Edmundson
On Sept. 1, 2015, 4:32 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125023/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 4:32 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> setSource is changing the current screen, so ensure we're putting the view where it belongs.
> Otherwise it gets in a ping pong cycle between both screens.
>
>
> Diffs
> -----
>
> shell/desktopview.cpp 8e20d44
>
> Diff: https://git.reviewboard.kde.org/r/125023/diff/
>
>
> Testing
> -------
>
> Now I can boot it (on my devel user, my normal user crashes for some reason, see further e-mail)
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150901/532559b2/attachment.html>
More information about the Plasma-devel
mailing list