Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

Bhushan Shah bhush94 at gmail.com
Sat Oct 31 12:41:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125892/
-----------------------------------------------------------

(Updated Oct. 31, 2015, 6:11 p.m.)


Review request for Plasma, David Edmundson and Martin Gräßlin.


Repository: plasma-workspace


Description (updated)
-------

To split libksld it is required that it no longer depends upon ksmserver being parent dir.

I am just unsure about removal of,

set(ksmserver_xml  ${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml)
and
qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface)


Diffs
-----

  ksmserver/config-ksmserver.h.cmake f24e62d 
  ksmserver/screenlocker/CMakeLists.txt 4213713 
  ksmserver/screenlocker/autotests/CMakeLists.txt 51eb0fe 
  ksmserver/screenlocker/config-kscreenlocker.h.cmake PRE-CREATION 
  ksmserver/screenlocker/greeter/CMakeLists.txt 942d88c 
  ksmserver/screenlocker/greeter/authenticator.cpp 4d916a1 
  ksmserver/screenlocker/greeter/autotests/CMakeLists.txt 4244a2a 
  ksmserver/screenlocker/waylandserver.cpp f8ef665 
  ksmserver/screenlocker/ksldapp.cpp f062082 
  ksmserver/screenlocker/kcm/kcm.cpp 751b566 
  ksmserver/screenlocker/kcm/CMakeLists.txt c5c62be 
  ksmserver/screenlocker/greeter/autotests/killtest.cpp 363c9f0 

Diff: https://git.reviewboard.kde.org/r/125892/diff/


Testing
-------

builds, installs, tests pass


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151031/322da1e8/attachment.html>


More information about the Plasma-devel mailing list