<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125892/">https://git.reviewboard.kde.org/r/125892/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, David Edmundson and Martin Gräßlin.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2015, 6:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To split libksld it is required that it no longer depends upon ksmserver being parent dir.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am just unsure about removal of,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">set(ksmserver_xml ${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml)
and
qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds, installs, tests pass</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/config-ksmserver.h.cmake <span style="color: grey">(f24e62d)</span></li>
<li>ksmserver/screenlocker/CMakeLists.txt <span style="color: grey">(4213713)</span></li>
<li>ksmserver/screenlocker/autotests/CMakeLists.txt <span style="color: grey">(51eb0fe)</span></li>
<li>ksmserver/screenlocker/config-kscreenlocker.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: grey">(942d88c)</span></li>
<li>ksmserver/screenlocker/greeter/authenticator.cpp <span style="color: grey">(4d916a1)</span></li>
<li>ksmserver/screenlocker/greeter/autotests/CMakeLists.txt <span style="color: grey">(4244a2a)</span></li>
<li>ksmserver/screenlocker/waylandserver.cpp <span style="color: grey">(f8ef665)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: grey">(f062082)</span></li>
<li>ksmserver/screenlocker/kcm/kcm.cpp <span style="color: grey">(751b566)</span></li>
<li>ksmserver/screenlocker/kcm/CMakeLists.txt <span style="color: grey">(c5c62be)</span></li>
<li>ksmserver/screenlocker/greeter/autotests/killtest.cpp <span style="color: grey">(363c9f0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125892/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>