Review Request 125873: preliminar support for task geometries in wayland

[Marco Martin]

> On Oct. 30, 2015, 2:32 p.m., Martin Gräßlin wrote:
> > main_wayland.cpp, lines 378-380
> > <https://git.reviewboard.kde.org/r/125873/diff/3/?file=413592#file413592line378>
> >
> >     only if you want to break kwin for everybody with an up to date Qt 5.6

ah, right sorry, forgot that :(


> On Oct. 30, 2015, 2:32 p.m., Martin Gräßlin wrote:
> > abstract_client.h, line 830
> > <https://git.reviewboard.kde.org/r/125873/diff/3/?file=413591#file413591line830>
> >
> >     why friend an inheriting class?

because m_windowManagementInterface is private in AbstractClient (should be protected?)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125873/#review87746
-----------------------------------------------------------


On Oct. 30, 2015, 1:43 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125873/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 1:43 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> make the minimize effect work by reading taskGeometry from plasmawindowmanagement and returning as iconGeometry().
> 
> It still supports a single taskbar as on x11. the architecture will have to change somehow to allow to know from where panel we want to minimize (or if not secified searching for the nearest panel)
> suggestions welcome :)
> 
> 
> Diffs
> -----
> 
>   shell_client.cpp b466f97 
>   shell_client.h fee22c4 
>   abstract_client.h 128c141 
>   main_wayland.cpp 5dc7e9f 
> 
> Diff: https://git.reviewboard.kde.org/r/125873/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151030/7080271f/attachment-0001.html>