Review Request 125873: preliminar support for task geometries in wayland

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125873/#review87746
-----------------------------------------------------------



abstract_client.h (line 830)
<https://git.reviewboard.kde.org/r/125873/#comment60193>

    why friend an inheriting class?



main_wayland.cpp (lines 378 - 380)
<https://git.reviewboard.kde.org/r/125873/#comment60192>

    only if you want to break kwin for everybody with an up to date Qt 5.6



shell_client.h (lines 41 - 47)
<https://git.reviewboard.kde.org/r/125873/#comment60194>

    instead of duplicating the propery, I suggest to move it to AbstractClient and add the method as a virtual.



shell_client.cpp (line 364)
<https://git.reviewboard.kde.org/r/125873/#comment60195>

    auto



shell_client.cpp (line 374)
<https://git.reviewboard.kde.org/r/125873/#comment60196>

    this crashes if we don't find a candidatePanel


- Martin Gräßlin


On Oct. 30, 2015, 2:43 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125873/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 2:43 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> make the minimize effect work by reading taskGeometry from plasmawindowmanagement and returning as iconGeometry().
> 
> It still supports a single taskbar as on x11. the architecture will have to change somehow to allow to know from where panel we want to minimize (or if not secified searching for the nearest panel)
> suggestions welcome :)
> 
> 
> Diffs
> -----
> 
>   shell_client.cpp b466f97 
>   shell_client.h fee22c4 
>   abstract_client.h 128c141 
>   main_wayland.cpp 5dc7e9f 
> 
> Diff: https://git.reviewboard.kde.org/r/125873/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151030/09520606/attachment.html>