Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125773/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 6:16 p.m.)


Review request for Plasma.


Changes
-------

Add screenshots before/after both with Noto Sans font (size 9) on display with 96 dpi. The popup width is the minimal popup width set by systray (unit.gridSize * 14). The same issue can be observed with Oxygen font.


Bugs: 343349
    http://bugs.kde.org/show_bug.cgi?id=343349


Repository: plasma-framework


Description (updated)
-------

For some fonts, QFontMetrics::boundingRect(QString) returns too high rect which makes the gridSize too big.
It now returns correctly the actual height of M character. For backwards compatibility, the value is multiplied with 1.6.

This affects eg. Noto Sans font that is now default for Plasma 5.5.


Diffs
-----

  src/declarativeimports/core/units.h fa2256e 
  src/declarativeimports/core/units.cpp 4e2adae 
  src/plasma/theme.cpp c49ad4c 

Diff: https://git.reviewboard.kde.org/r/125773/diff/


Testing
-------

When switching to Noto Sans font, I noticed that icons in system tray grow to big size so it switched to 1 column in vertical panel. Basically everything in Plasma grow too much (even though the font is visually the same or even smaller than DejaVu Sans that I was using before - same font size 9 was used) - too big spacing in task manager, too big popups (application menu, system tray popups), etc ...

This fixes the issue. This may also fix BUG 343349


File Attachments (updated)
----------------

systray + popup before
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d409b391-e35e-451f-bb5b-aa42e7eb2bf3__before.png
after
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/445009bc-a4a8-4998-8e82-996a0a4e33fb__after.png


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151029/9ebf8eb5/attachment-0001.html>