Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125773/
-----------------------------------------------------------

(Updated Oct. 24, 2015, 3:22 p.m.)


Review request for Plasma.


Changes
-------

Only multiply height in Theme::mSize


Bugs: 343349
    http://bugs.kde.org/show_bug.cgi?id=343349


Repository: plasma-framework


Description
-------

For some fonts, QFontMetrics::boundingRect(QString) too high rect which makes the gridSize too big.
It now returns correctly the actual height of M character. For backwards compatibility, the value is multiplied with 1.6.

This affects eg. Noto Sans font that is now default for Plasma 5.5.


Diffs (updated)
-----

  src/declarativeimports/core/units.h fa2256e 
  src/declarativeimports/core/units.cpp 4e2adae 
  src/plasma/theme.cpp c49ad4c 

Diff: https://git.reviewboard.kde.org/r/125773/diff/


Testing
-------

When switching to Noto Sans font, I noticed that icons in system tray grow to big size so it switched to 1 column in vertical panel. Basically everything in Plasma grow too much (even though the font is visually the same or even smaller than DejaVu Sans that I was using before - same font size 9 was used) - too big spacing in task manager, too big popups (application menu, system tray popups), etc ...

This fixes the issue. This may also fix BUG 343349


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151024/c6429ad9/attachment.html>