Review Request 125844: Use PATH_VARS feature of ecm_configure_package_config_file

Alex Merry alex.merry at kde.org
Wed Oct 28 20:19:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125844/#review87615
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On Oct. 28, 2015, 5:40 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125844/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 5:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This makes specifying absolute paths on the commandline that are then
> encoded into the config file work.
> Not hard-coding the packackage prefix is also helpful on a multiarch
> layout where the prefix is /usr/${host} but arch-independent files
> should still be installed to /usr/share (i.e a level below the
> prefix).
> 
> 
> Diffs
> -----
> 
>   krunner/CMakeLists.txt e1329282fe7078b5d57f1feb2c7de960c640db7b 
>   krunner/KRunnerAppDBusInterfaceConfig.cmake.in ecbfc5afc73def0303442413ae60232191fee0ff 
>   ksmserver/CMakeLists.txt a0c8852673ac9e69e2cc053107eec60122ec069b 
>   ksmserver/KSMServerDBusInterfaceConfig.cmake.in e16e571bfd77ed71c53972705659a6d3053739f8 
>   ksmserver/screenlocker/CMakeLists.txt 203508c63e7851d566dfbfbdc77ac29f35e588c2 
>   ksmserver/screenlocker/ScreenSaverDBusInterfaceConfig.cmake.in 832677e63b2423a28ea44b3a38b8e122ee93e643 
> 
> Diff: https://git.reviewboard.kde.org/r/125844/diff/
> 
> 
> Testing
> -------
> 
> Installed, the paths in the cmake config files point correctly to the dbus interface files.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151028/c37e1e3e/attachment.html>


More information about the Plasma-devel mailing list