<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125844/">https://git.reviewboard.kde.org/r/125844/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On October 28th, 2015, 5:40 p.m. UTC, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2015, 5:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This makes specifying absolute paths on the commandline that are then
encoded into the config file work.
Not hard-coding the packackage prefix is also helpful on a multiarch
layout where the prefix is /usr/${host} but arch-independent files
should still be installed to /usr/share (i.e a level below the
prefix).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Installed, the paths in the cmake config files point correctly to the dbus interface files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krunner/CMakeLists.txt <span style="color: grey">(e1329282fe7078b5d57f1feb2c7de960c640db7b)</span></li>
<li>krunner/KRunnerAppDBusInterfaceConfig.cmake.in <span style="color: grey">(ecbfc5afc73def0303442413ae60232191fee0ff)</span></li>
<li>ksmserver/CMakeLists.txt <span style="color: grey">(a0c8852673ac9e69e2cc053107eec60122ec069b)</span></li>
<li>ksmserver/KSMServerDBusInterfaceConfig.cmake.in <span style="color: grey">(e16e571bfd77ed71c53972705659a6d3053739f8)</span></li>
<li>ksmserver/screenlocker/CMakeLists.txt <span style="color: grey">(203508c63e7851d566dfbfbdc77ac29f35e588c2)</span></li>
<li>ksmserver/screenlocker/ScreenSaverDBusInterfaceConfig.cmake.in <span style="color: grey">(832677e63b2423a28ea44b3a38b8e122ee93e643)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125844/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>