Review Request 125839: Quicklaunch: Show default icon when launcher icon is empty

[David Rosca]

> On Oct. 28, 2015, 12:24 p.m., David Edmundson wrote:
> > applets/quicklaunch/package/contents/ui/IconItem.qml, line 35
> > <https://git.reviewboard.kde.org/r/125839/diff/1/?file=413122#file413122line35>
> >
> >     sexy QML tip for future
> >     
> >     you can also write this as
> >     
> >     iconName: launcher.iconName || "fork"
> >     
> >     it's a tiny bit faster to execute and once we start getting used to this syntax it's easier to read.

Thanks, I'll remember it :)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125839/#review87574
-----------------------------------------------------------


On Oct. 28, 2015, 1:08 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125839/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 1:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Always show icon, even when launcher icon is empty.
> 
> 
> Diffs
> -----
> 
>   applets/quicklaunch/package/contents/ui/IconItem.qml 0e449f7 
> 
> Diff: https://git.reviewboard.kde.org/r/125839/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151028/f9c236f2/attachment.html>