Review Request 125839: Quicklaunch: Show default icon when launcher icon is empty

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125839/#review87574
-----------------------------------------------------------

Ship it!



applets/quicklaunch/package/contents/ui/IconItem.qml (line 35)
<https://git.reviewboard.kde.org/r/125839/#comment60126>

    sexy QML tip for future
    
    you can also write this as
    
    iconName: launcher.iconName || "fork"
    
    it's a tiny bit faster to execute and once we start getting used to this syntax it's easier to read.


- David Edmundson


On Oct. 28, 2015, 11:52 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125839/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 11:52 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Always show icon, even when launcher icon is empty.
> 
> 
> Diffs
> -----
> 
>   applets/quicklaunch/package/contents/ui/IconItem.qml 0e449f7 
> 
> Diff: https://git.reviewboard.kde.org/r/125839/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151028/33566057/attachment.html>