Review Request 125812: Fix icon-based status notifier icons

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125812/#review87440
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Oct. 26, 2015, 5:03 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125812/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 5:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Normally check if the value is correct by checking if it's different to null.
> Use a property rather than a function, so that if a value changes, it gets picked up. Additionally this will make it share the value rather than rendering the icon twice (one for each use).
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/StatusNotifierItem.qml d2cc2f6 
> 
> Diff: https://git.reviewboard.kde.org/r/125812/diff/
> 
> 
> Testing
> -------
> 
> I don't get empty spaces anymore.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151026/053a44bf/attachment.html>