Review Request 125812: Fix icon-based status notifier icons
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Oct 26 17:03:34 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125812/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
Normally check if the value is correct by checking if it's different to null.
Use a property rather than a function, so that if a value changes, it gets picked up. Additionally this will make it share the value rather than rendering the icon twice (one for each use).
Diffs
-----
applets/systemtray/package/contents/ui/StatusNotifierItem.qml d2cc2f6
Diff: https://git.reviewboard.kde.org/r/125812/diff/
Testing
-------
I don't get empty spaces anymore.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151026/7ea9ca4d/attachment.html>
More information about the Plasma-devel
mailing list