Review Request 125805: Improve lockwindow test

Bhushan Shah bhush94 at gmail.com
Mon Oct 26 09:43:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125805/
-----------------------------------------------------------

(Updated Oct. 26, 2015, 3:13 p.m.)


Review request for Plasma and Martin Gräßlin.


Changes
-------

now verifies if 0,0,100,100 is red


Repository: plasma-workspace


Description
-------

Earlier we were creating dummy window but it was just black/transperant, so given that isBlack check would succeed even if lockwindow is not shown in some cases.


Diffs (updated)
-----

  ksmserver/screenlocker/autotests/lockwindowtest.cpp 444c44f 

Diff: https://git.reviewboard.kde.org/r/125805/diff/


Testing
-------

tests pass


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151026/33174954/attachment.html>


More information about the Plasma-devel mailing list