Review Request 125805: Improve lockwindow test
Martin Gräßlin
mgraesslin at kde.org
Mon Oct 26 09:25:49 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125805/#review87412
-----------------------------------------------------------
please verify that the background is colored at the expected places.
- Martin Gräßlin
On Oct. 26, 2015, 10:18 a.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125805/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 10:18 a.m.)
>
>
> Review request for Plasma and Martin Gräßlin.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Earlier we were creating dummy window but it was just black/transperant, so given that isBlack check would succeed even if lockwindow is not shown in some cases.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/autotests/lockwindowtest.cpp 444c44f
>
> Diff: https://git.reviewboard.kde.org/r/125805/diff/
>
>
> Testing
> -------
>
> tests pass
>
>
> Thanks,
>
> Bhushan Shah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151026/5069fa4d/attachment.html>
More information about the Plasma-devel
mailing list