Review Request 125727: [ksplash] refrect windowState correctly

[Takahiro Hashimoto]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125727/
-----------------------------------------------------------

(Updated Oct. 22, 2015, 7:50 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit c5970ae34c81d5a4d8e868afc145352c8a3647ba by Takahiro Hashimoto to branch master.


Repository: plasma-workspace


Description
-------

QWindow.show() doesn't refrect its windowState property which is set by manual. As ksplashqml treats windowState(expected to be set to Qt::WindowFullScreen) we should use QWindow.setVisible(true) instead.

At present the ksplashqml view size is adjusted to the screen size by another implementation (syncResizeMode()). We might discuss about handling windowState flag.  I think we expect splashscreen is displayed full-screen and handling windowState is correct approach.


Diffs
-----

  ksplash/ksplashqml/splashapp.cpp 8ad4f4d 

Diff: https://git.reviewboard.kde.org/r/125727/diff/


Testing
-------

applied the patch and confirmed that ksplashqml (with/without "--test") shown full-screen.


Thanks,

Takahiro Hashimoto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151022/002709b4/attachment.html>