Review Request 125727: [ksplash] refrect windowState correctly

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125727/#review87230
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Oct. 20, 2015, 4:05 p.m., Takahiro Hashimoto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125727/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 4:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> QWindow.show() doesn't refrect its windowState property which is set by manual. As ksplashqml treats windowState(expected to be set to Qt::WindowFullScreen) we should use QWindow.setVisible(true) instead.
> 
> At present the ksplashqml view size is adjusted to the screen size by another implementation (syncResizeMode()). We might discuss about handling windowState flag.  I think we expect splashscreen is displayed full-screen and handling windowState is correct approach.
> 
> 
> Diffs
> -----
> 
>   ksplash/ksplashqml/splashapp.cpp 8ad4f4d 
> 
> Diff: https://git.reviewboard.kde.org/r/125727/diff/
> 
> 
> Testing
> -------
> 
> applied the patch and confirmed that ksplashqml (with/without "--test") shown full-screen.
> 
> 
> Thanks,
> 
> Takahiro Hashimoto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151021/982cf6c0/attachment.html>