Review Request 125705: Use LANG for month names in calendar applet

Martin Klapetek martin.klapetek at gmail.com
Tue Oct 20 19:04:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/
-----------------------------------------------------------

(Updated Oct. 20, 2015, 9:04 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

Construct QLocale from QLocale().uiLanguages().first().


Bugs: 353715
    http://bugs.kde.org/show_bug.cgi?id=353715


Repository: plasma-framework


Description
-------

Simple QDate::longMonthName won't do the job as it
will return the month name using LC_DATE locale which is used
for date formatting etc. So for example, in en_US locale
and cs_CZ LC_DATE, it would return Czech month names while
it should return English ones. So here we force the LANG
locale and take the month name from that.


Diffs (updated)
-----

  src/declarativeimports/calendar/calendar.cpp 67a08e5 

Diff: https://git.reviewboard.kde.org/r/125705/diff/


Testing
-------

LC_DATE=cs_CZ
LANG=en_US

Month names in calendar applet are now english.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151020/f716dcd9/attachment-0001.html>


More information about the Plasma-devel mailing list