Review Request 125705: Use LANG for month names in calendar applet

[Martin Klapetek]

> On Oct. 20, 2015, 9:12 a.m., Xuetian Weng wrote:
> > src/declarativeimports/calendar/calendar.cpp, line 195
> > <https://git.reviewboard.kde.org/r/125705/diff/1/?file=411749#file411749line195>
> >
> >     This only checks LANG, meanwhile, LC_ALL and LC_MESSAGES, and maybe even LANGUAGE should also be considered.
> >     
> >     But I guess using the first item from QLocale().uiLanguages() would just work.

Ok.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87113
-----------------------------------------------------------


On Oct. 19, 2015, 6:13 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
>     http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> -------
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151020/a28b3488/attachment.html>