Review Request 125669: Remove redundant code

David Edmundson david at davidedmundson.co.uk
Sat Oct 17 12:11:21 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125669/
-----------------------------------------------------------

(Updated Oct. 17, 2015, 12:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit bca23eaa323d68b13a954138af0ea1a6aaac71eb by David Edmundson to branch master.


Repository: plasma-workspace


Description
-------

We have a

connect(KWindowSystem::self(), &KWindowSystem::showingDesktopChanged,
[dashboardAction](bool showing) {
        dashboardAction->setText(showing ? i18n("Hide Dashboard") :
i18n("Show Dashboard"));

in the class constructor. Changing when we're invoked manually is pointless.


Diffs
-----

  shell/shellcorona.cpp b52a7a13b49be184915b1cb350d2e81fe4dffeac 

Diff: https://git.reviewboard.kde.org/r/125669/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151017/ecfb83e6/attachment.html>


More information about the Plasma-devel mailing list