Review Request 125669: Remove redundant code
Kai Uwe Broulik
kde at privat.broulik.de
Sat Oct 17 12:03:28 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125669/#review86958
-----------------------------------------------------------
Ship it!
Ship It!
- Kai Uwe Broulik
On Okt. 17, 2015, 9:51 vorm., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125669/
> -----------------------------------------------------------
>
> (Updated Okt. 17, 2015, 9:51 vorm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> We have a
>
> connect(KWindowSystem::self(), &KWindowSystem::showingDesktopChanged,
> [dashboardAction](bool showing) {
> dashboardAction->setText(showing ? i18n("Hide Dashboard") :
> i18n("Show Dashboard"));
>
> in the class constructor. Changing when we're invoked manually is pointless.
>
>
> Diffs
> -----
>
> shell/shellcorona.cpp b52a7a13b49be184915b1cb350d2e81fe4dffeac
>
> Diff: https://git.reviewboard.kde.org/r/125669/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151017/2242dd7a/attachment.html>
More information about the Plasma-devel
mailing list