Review Request 125654: Use shared engine in ksplashqml

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125654/#review86909
-----------------------------------------------------------


+1, looks good to me


ksplash/ksplashqml/splashapp.cpp (line 127)
<https://git.reviewboard.kde.org/r/125654/#comment59766>

    not only is it more correct as you write in the summary, it is also wrong. We want the splash screen to cover everything (like a fullscreen window), so excluding the panels was clearly wrong.


- Martin Gräßlin


On Oct. 16, 2015, 12:18 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125654/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 12:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> As Martin G analysed in kscreenlocker_greet this cuts down a lot of time
> on dual monitors.
> 
> 
> ---------
> 
> Don't include struts in initial ksplash geometry
> 
> We initially set a ksplash window to a screen's availableGeometry then
> monitored and screen->geometry. Using a mix is definitely wrong.
> 
> Won't make any practical difference as this is all started long before
> plasmashell, but it's technically more correct.
> 
> 
> Diffs
> -----
> 
>   ksplash/ksplashqml/splashwindow.h 2afda0b3523ee0a3218f711dadf391e2128ecf8b 
>   ksplash/ksplashqml/splashapp.cpp 570c65c3e4b71595977162b6ec81f2309552839e 
>   ksplash/ksplashqml/CMakeLists.txt ce55b8e6ca7e8556935325fdee86d396cdce77fb 
>   ksplash/ksplashqml/splashwindow.cpp 3e00ebac617fe49d7d25c08c86ec1f8975f957e1 
> 
> Diff: https://git.reviewboard.kde.org/r/125654/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151016/bfdce904/attachment.html>