Review Request 125654: Use shared engine in ksplashqml

David Edmundson david at davidedmundson.co.uk
Fri Oct 16 10:18:59 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125654/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-workspace


Description
-------

As Martin G analysed in kscreenlocker_greet this cuts down a lot of time
on dual monitors.


---------

Don't include struts in initial ksplash geometry

We initially set a ksplash window to a screen's availableGeometry then
monitored and screen->geometry. Using a mix is definitely wrong.

Won't make any practical difference as this is all started long before
plasmashell, but it's technically more correct.


Diffs
-----

  ksplash/ksplashqml/splashwindow.h 2afda0b3523ee0a3218f711dadf391e2128ecf8b 
  ksplash/ksplashqml/splashapp.cpp 570c65c3e4b71595977162b6ec81f2309552839e 
  ksplash/ksplashqml/CMakeLists.txt ce55b8e6ca7e8556935325fdee86d396cdce77fb 
  ksplash/ksplashqml/splashwindow.cpp 3e00ebac617fe49d7d25c08c86ec1f8975f957e1 

Diff: https://git.reviewboard.kde.org/r/125654/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151016/f3d5365d/attachment.html>


More information about the Plasma-devel mailing list