Review Request 125622: Use better guard against recursion when changing volume with sliders

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125622/
-----------------------------------------------------------

(Updated Oct. 15, 2015, 2:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 3d77132a1ca918ca4082c5078833ec1b4817bc20 by David Rosca to branch Plasma/5.4.


Repository: plasma-pa


Description
-------

As noted in https://git.reviewboard.kde.org/r/125088/, this should fix acessibility on volume sliders.
This also fixes changing the volume with keyboard (when slider has focus).


Diffs
-----

  applet/contents/ui/ListItemBase.qml 54f6eb0 
  src/kcm/package/contents/ui/VolumeSlider.qml da77315 

Diff: https://git.reviewboard.kde.org/r/125622/diff/


Testing
-------

Changing volume in applet still works + it fixes changing volume in kcm (i broke it with last commit - there is no setVolume() in kcm VolumeSlider).


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151015/ce221893/attachment.html>