Review Request 125622: Use better guard against recursion when changing volume with sliders

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125622/#review86814
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Oct. 13, 2015, 3:21 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125622/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 3:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> As noted in https://git.reviewboard.kde.org/r/125088/, this should fix acessibility on volume sliders.
> This also fixes changing the volume with keyboard (when slider has focus).
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ListItemBase.qml 54f6eb0 
>   src/kcm/package/contents/ui/VolumeSlider.qml da77315 
> 
> Diff: https://git.reviewboard.kde.org/r/125622/diff/
> 
> 
> Testing
> -------
> 
> Changing volume in applet still works + it fixes changing volume in kcm (i broke it with last commit - there is no setVolume() in kcm VolumeSlider).
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151013/ab1736b2/attachment.html>