Review Request 125562: Default for look and feel of applets, take 2

Marco Martin notmart at gmail.com
Tue Oct 13 11:08:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125562/
-----------------------------------------------------------

(Updated Oct. 13, 2015, 11:08 a.m.)


Review request for Plasma and Eike Hein.


Changes
-------

in this last version, some changes to the systray as well, now the scripts work for the systray plasmoids too


Repository: plasma-workspace


Description
-------

(draft) mutually exclusive with https://git.reviewboard.kde.org/r/125558/
a bit more flexible
different approach: execute a script from the look and feel package when an applet is added, adding to the script environment "applet" that wraps the currently added applet and "containment" that wraps its containment.
from there the javascript part can do anything it can do in the startup script as well.
Still missing, something similar will have to be executed when a new containment is added as well.


Diffs (updated)
-----

  applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp 128d664 
  applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp ff61d3e 
  shell/packageplugins/lookandfeel/lookandfeel.cpp a6cef04 
  shell/shellcorona.h 0e6fe04 
  shell/shellcorona.cpp 37d0534 

Diff: https://git.reviewboard.kde.org/r/125562/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151013/0c1027d4/attachment.html>


More information about the Plasma-devel mailing list