Review Request 125562: Default for look and feel of applets, take 2

Marco Martin notmart at gmail.com
Mon Oct 12 14:47:11 UTC 2015



> On Oct. 12, 2015, 1:53 p.m., David Edmundson wrote:
> > do we want this to work for applets in the system tray ?

good question.. ideally yes, and as is now it *may* work, modulo the fact that i'm not sure how to connect the sub-containment of the systray, will just have to be the usual hardcoded special case children  (i really wish i could change how the systray works, but is ages i say that :p)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125562/#review86720
-----------------------------------------------------------


On Oct. 9, 2015, 4:29 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125562/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 4:29 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> (draft) mutually exclusive with https://git.reviewboard.kde.org/r/125558/
> a bit more flexible
> different approach: execute a script from the look and feel package when an applet is added, adding to the script environment "applet" that wraps the currently added applet and "containment" that wraps its containment.
> from there the javascript part can do anything it can do in the startup script as well.
> Still missing, something similar will have to be executed when a new containment is added as well.
> 
> 
> Diffs
> -----
> 
>   shell/packageplugins/lookandfeel/lookandfeel.cpp a6cef04 
>   shell/shellcorona.h 0e6fe04 
>   shell/shellcorona.cpp 37d0534 
> 
> Diff: https://git.reviewboard.kde.org/r/125562/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151012/e51fde5e/attachment.html>


More information about the Plasma-devel mailing list