Review Request 125088: Allow to change volume with mouse wheel in kcm

David Rosca nowrep at gmail.com
Tue Oct 13 09:50:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125088/
-----------------------------------------------------------

(Updated Oct. 13, 2015, 9:50 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Harald Sitter.


Changes
-------

Submitted with commit a81d5e847969f7c640c81bf710af99c1bf1a2669 by David Rosca to branch Plasma/5.4.


Repository: plasma-pa


Description
-------

Implement changing volume on mouse wheel.
Also block wheel events on sliders in applet.

Without this patch, the value of slider gets changed but it won't change the actual volume.


Diffs
-----

  applet/contents/ui/ListItemBase.qml 8993b16 
  src/kcm/package/contents/ui/VolumeSlider.qml c36dd33 

Diff: https://git.reviewboard.kde.org/r/125088/diff/


Testing
-------

Changing volume with wheel works in kcm. Trying to use wheel on sliders in applet does nothing.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151013/a641b2bf/attachment.html>


More information about the Plasma-devel mailing list