Review Request 125088: Allow to change volume with mouse wheel in kcm

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125088/#review86794
-----------------------------------------------------------



src/kcm/package/contents/ui/VolumeSlider.qml (line 64)
<https://git.reviewboard.kde.org/r/125088/#comment59704>

    one thing we should somehow fix is this line breaks accessibility
    
    The QQC slider has an Accessible.increaseAction method specfied that increases value.
    
    we'll detect we're not pressed and not update the volume.
    
    (this problem existed before this patch, so no need to solve this right now)


- David Edmundson


On Oct. 12, 2015, 5:06 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125088/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 5:06 p.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Implement changing volume on mouse wheel.
> Also block wheel events on sliders in applet.
> 
> Without this patch, the value of slider gets changed but it won't change the actual volume.
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ListItemBase.qml 8993b16 
>   src/kcm/package/contents/ui/VolumeSlider.qml c36dd33 
> 
> Diff: https://git.reviewboard.kde.org/r/125088/diff/
> 
> 
> Testing
> -------
> 
> Changing volume with wheel works in kcm. Trying to use wheel on sliders in applet does nothing.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151013/5b4d66ab/attachment.html>