Review Request 125562: Default for look and feel of applets, take 2

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125562/#review86554
-----------------------------------------------------------


+1 (save for two minor comments)


shell/shellcorona.cpp (line 1038)
<https://git.reviewboard.kde.org/r/125562/#comment59601>

    connect(c, &Thing, [this,c](){});
    
    should be
    
    connect(c, &Thing, this, [this,c](){});
    
    otherwise if ShellCorona gets deleted we end up still with our slot connected and explode.
    
    (I think shellcorona probably outlives containments, but better save than sorry)



shell/shellcorona.cpp (line 1075)
<https://git.reviewboard.kde.org/r/125562/#comment59681>

    we should export activity as a property.
    
    it's not availabe from Applet


could we use if (id==0) rather than introducing new signals in p-f?

- David Edmundson


On Oct. 9, 2015, 4:29 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125562/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 4:29 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> (draft) mutually exclusive with https://git.reviewboard.kde.org/r/125558/
> a bit more flexible
> different approach: execute a script from the look and feel package when an applet is added, adding to the script environment "applet" that wraps the currently added applet and "containment" that wraps its containment.
> from there the javascript part can do anything it can do in the startup script as well.
> Still missing, something similar will have to be executed when a new containment is added as well.
> 
> 
> Diffs
> -----
> 
>   shell/packageplugins/lookandfeel/lookandfeel.cpp a6cef04 
>   shell/shellcorona.h 0e6fe04 
>   shell/shellcorona.cpp 37d0534 
> 
> Diff: https://git.reviewboard.kde.org/r/125562/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151012/5622377e/attachment.html>