Review Request 125562: Default for look and feel of applets, take 2

[David Edmundson]

> On Oct. 12, 2015, 1:01 p.m., Marco Martin wrote:
> > One problem that i think it makes not really possible to use layout templates to doing this for containments, is that this assumes that a containment gets created and *then* a script is executed on it, while layout templates create the containment themselves (here's from the default panel)
> > var panel = new Panel
> > var panelScreen = panel.screen
> > var freeEdges = {"bottom": true, "top": true, "left": true, "right": true}
> > 
> > one thing that could be made is to not run this for containment, but in Activity.cpp when the default containment plugin is searched for to search for a layout template first (that would also mean we have to manage when the script is wrong and does not create the containment as expected)

>but in Activity.cpp when the default containment plugin is searched for to search for a layout template first (that would also mean we have to manage when the script is wrong and does not create the containment as expected)

OK, I think that's a better place to cover the one hook I think is missing - and to look at merging existing "creating new stuff" code.

I'm happy with that then.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125562/#review86714
-----------------------------------------------------------


On Oct. 9, 2015, 4:29 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125562/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 4:29 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> (draft) mutually exclusive with https://git.reviewboard.kde.org/r/125558/
> a bit more flexible
> different approach: execute a script from the look and feel package when an applet is added, adding to the script environment "applet" that wraps the currently added applet and "containment" that wraps its containment.
> from there the javascript part can do anything it can do in the startup script as well.
> Still missing, something similar will have to be executed when a new containment is added as well.
> 
> 
> Diffs
> -----
> 
>   shell/packageplugins/lookandfeel/lookandfeel.cpp a6cef04 
>   shell/shellcorona.h 0e6fe04 
>   shell/shellcorona.cpp 37d0534 
> 
> Diff: https://git.reviewboard.kde.org/r/125562/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151012/762e68eb/attachment-0001.html>