Review Request 125555: Don't start an eventLoop from QML in menu entry editing

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125555/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-desktop


Description
-------

>From the docs:
This is dangerous, because when an event loop is entered in a signal
handler or binding, the QML engine continues to run other bindings,
animations, transitions, etc. Those bindings can then cause side effects
which, for example, destroy the hierarchy containing your event loop.

BUG: 347997

Port KAuth return code error checking in fontinst

Someone whilst porting had simply commented it out
This causes the install dialog to freeze if there's a problem.

CCBUG: 344473
CCBUG: 300951
CCBUG: 345234


Diffs
-----

  kcms/kfontinst/dbus/FontInst.cpp 42413c1a05717f416681ef32317b8914c2ba35ec 

Diff: https://git.reviewboard.kde.org/r/125555/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151008/4cf8ae6e/attachment.html>