Review Request 125553: Honor ShellSurfaceInterface::acceptsKeyboardFocus in ::wantsInput

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125553/
-----------------------------------------------------------

(Updated Oct. 8, 2015, 10:52 a.m.)


Status
------

This change has been marked as submitted.


Review request for kwin and Plasma.


Changes
-------

Submitted with commit 29b2082daaaaff07a379a2c66d0c180fbfe356c3 by Martin Gräßlin to branch master.


Repository: kwin


Description
-------

[wayland] Proper metatype for ShellClient
Needs meta type declared and properly used in WaylandServer.

[wayland] Honor ShellSurfaceInterface::acceptsKeyboardFocus in ::wantsInput

If the surface indicates that it doesn't want keyboard focus we shouldn't
give it keyboard focus.

This was a problem with Kate's autocompletion tool tip windows.


Diffs
-----

  autotests/wayland/CMakeLists.txt 43b8eb8bc0e149797f70ceac175a0cabf6aae8f9 
  autotests/wayland/transient_no_input_test.cpp PRE-CREATION 
  shell_client.h fa64253a4fcb4392c41e649b96b955402ad87016 
  shell_client.cpp a45153286bb827ffbd3ba776cc09b03438dc5d42 
  wayland_server.h 57fec168bacd8101857629ca3339ebc01ebb3a98 

Diff: https://git.reviewboard.kde.org/r/125553/diff/


Testing
-------

Triggered auto-completion tooltips in Kate


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151008/a67bc2e1/attachment.html>