Review Request 125547: kscreen effect: Intercept mouse and set blank cursor

Kai Uwe Broulik kde at privat.broulik.de
Thu Oct 8 07:48:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125547/#review86474
-----------------------------------------------------------


+1 from me

I think the user of the effect wants the screen to darken and with that we should also prevent accidental mouse clicks.

- Kai Uwe Broulik


On Okt. 7, 2015, 12:55 nachm., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125547/
> -----------------------------------------------------------
> 
> (Updated Okt. 7, 2015, 12:55 nachm.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> The whole screen is turned black with kscreen effect, so we should intercept mouse to prevent accidental clicks.
> Also, it looks better with no visible cursor.
> 
> 
> Diffs
> -----
> 
>   effects/kscreen/kscreen.cpp 67f4551 
> 
> Diff: https://git.reviewboard.kde.org/r/125547/diff/
> 
> 
> Testing
> -------
> 
> Cursor is hidden when effect is active.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151008/519328da/attachment.html>


More information about the Plasma-devel mailing list