Review Request 125547: kscreen effect: Intercept mouse and set blank cursor

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125547/#review86467
-----------------------------------------------------------


I think that's the wrong place to do it. If that's what KScreen wants to do, KScreen should take care of it and the behavior should not be bound to an effect. If we don't want to see a cursor why should it be bound to whether that effect is active?

Concerning whether we want to see the cursor I suggest to get feedback from the VDG.

- Martin Gräßlin


On Oct. 7, 2015, 2:55 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125547/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 2:55 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> The whole screen is turned black with kscreen effect, so we should intercept mouse to prevent accidental clicks.
> Also, it looks better with no visible cursor.
> 
> 
> Diffs
> -----
> 
>   effects/kscreen/kscreen.cpp 67f4551 
> 
> Diff: https://git.reviewboard.kde.org/r/125547/diff/
> 
> 
> Testing
> -------
> 
> Cursor is hidden when effect is active.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151008/b220a283/attachment.html>