Review Request 125468: [server] ShellSurface's transient is a dedicated mode

Martin Gräßlin mgraesslin at kde.org
Thu Oct 1 15:28:44 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125468/
-----------------------------------------------------------

(Updated Oct. 1, 2015, 3:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Marco Martin.


Changes
-------

Submitted with commit 38bb1c0855effd9551362efe4482a89983a07cfc by Martin Gräßlin to branch master.


Repository: kwayland


Description
-------

So far transient was a mutual exclusive mode causing a transient window
to not be able to be fullscreen. This seems wrong. Let's have transient
still as a dedicated mode allowing the window to be maximized and/or
fullscreen. Only popup stays a dedicated mode.


Diffs
-----

  autotests/client/test_wayland_shell.cpp 7bbdbb1a34a8848e8cfb1a58f7c0666e78b5432a 
  src/server/shell_interface.cpp 0b6b4312ea0e0d7b2e9e9b674d7f821b4f82cb70 

Diff: https://git.reviewboard.kde.org/r/125468/diff/


Testing
-------

Test app opens fullscreen again.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151001/2b4610c5/attachment-0001.html>


More information about the Plasma-devel mailing list