Review Request 125468: [server] ShellSurface's transient is a dedicated mode

Martin Gräßlin mgraesslin at kde.org
Thu Oct 1 06:47:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125468/#review86185
-----------------------------------------------------------


Requires also https://git.reviewboard.kde.org/r/125469/ for the Fullscreen panel test

- Martin Gräßlin


On Oct. 1, 2015, 8:39 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125468/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 8:39 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> So far transient was a mutual exclusive mode causing a transient window
> to not be able to be fullscreen. This seems wrong. Let's have transient
> still as a dedicated mode allowing the window to be maximized and/or
> fullscreen. Only popup stays a dedicated mode.
> 
> 
> Diffs
> -----
> 
>   autotests/client/test_wayland_shell.cpp 7bbdbb1a34a8848e8cfb1a58f7c0666e78b5432a 
>   src/server/shell_interface.cpp 0b6b4312ea0e0d7b2e9e9b674d7f821b4f82cb70 
> 
> Diff: https://git.reviewboard.kde.org/r/125468/diff/
> 
> 
> Testing
> -------
> 
> Test app opens fullscreen again.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151001/a842e287/attachment.html>


More information about the Plasma-devel mailing list