Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

David Rosca nowrep at gmail.com
Thu Oct 1 08:05:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125465/
-----------------------------------------------------------

(Updated Oct. 1, 2015, 8:05 a.m.)


Review request for Plasma.


Changes
-------

Use configure file for defines + cleanup

 - not need to find \_XiGetDevicePresenceNotifyEvent because it is not used
 - we need both XCB and X11 XInput, so merge them to single define


Bugs: 346336
    https://bugs.kde.org/show_bug.cgi?id=346336


Repository: plasma-desktop


Description
-------

xcb-xinput is not available on some distributions (eg. Debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227).
This patch adds udev device discovery to reapply settings when adding new keyboard / mouse.


Diffs (updated)
-----

  CMakeLists.txt 193238a 
  cmake/modules/FindUDev.cmake PRE-CREATION 
  kcms/keyboard/CMakeLists.txt 99f4bb3 
  kcms/keyboard/config-keyboard.h.cmake PRE-CREATION 
  kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5 
  kcms/keyboard/kcm_add_layout_dialog.cpp 64551d9 
  kcms/keyboard/kcm_keyboard_widget.h 5994ea4 
  kcms/keyboard/tests/CMakeLists.txt 5d7a3e7 
  kcms/keyboard/udev_helper.h PRE-CREATION 
  kcms/keyboard/udev_helper.cpp PRE-CREATION 
  kcms/keyboard/xinput_helper.h af70365 
  kcms/keyboard/xinput_helper.cpp 0ad7e9c 
  kcms/keyboard/xkb_rules.h ecebd6d 

Diff: https://git.reviewboard.kde.org/r/125465/diff/


Testing
-------

Plugging in keyboard is now correctly recognized.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151001/fd0816f7/attachment.html>


More information about the Plasma-devel mailing list