Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125465/#review86182
-----------------------------------------------------------


Did you check KWin's udev helper classes? Instead of re-inventing the wheel it might be better to share the code in case it would be useful. It's in kwin.git/udev.h and udev.cpp


kcms/keyboard/CMakeLists.txt (line 16)
<https://git.reviewboard.kde.org/r/125465/#comment59422>

    please use a configure file (yes it should have been like that for the other as well, but when we touch it, it's a good idea to improve ;-) )


- Martin Gräßlin


On Sept. 30, 2015, 9:55 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125465/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 9:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346336
>     https://bugs.kde.org/show_bug.cgi?id=346336
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> xcb-xinput is not available on some distributions (eg. Debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227).
> This patch adds udev device discovery to reapply settings when adding new keyboard / mouse.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 193238a 
>   cmake/modules/FindUDev.cmake PRE-CREATION 
>   kcms/keyboard/CMakeLists.txt 99f4bb3 
>   kcms/keyboard/tests/CMakeLists.txt 5d7a3e7 
>   kcms/keyboard/udev_helper.h PRE-CREATION 
>   kcms/keyboard/udev_helper.cpp PRE-CREATION 
>   kcms/keyboard/xinput_helper.h af70365 
>   kcms/keyboard/xinput_helper.cpp 0ad7e9c 
> 
> Diff: https://git.reviewboard.kde.org/r/125465/diff/
> 
> 
> Testing
> -------
> 
> Plugging in keyboard is now correctly recognized.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151001/607921be/attachment.html>