Review Request 126168: [IconItem] Don't crash on no icon theme

Kai Uwe Broulik kde at privat.broulik.de
Wed Nov 25 17:18:47 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126168/
-----------------------------------------------------------

(Updated Nov. 25, 2015, 5:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 9ccc6293f792bb5a5cae624568c0073a73064b88 by Kai Uwe Broulik to branch master.


Bugs: 355577
    http://bugs.kde.org/show_bug.cgi?id=355577


Repository: plasma-framework


Description
-------

According to the docs theme() in KIconLoader can return null. Guard for this.


Diffs
-----

  src/declarativeimports/core/iconitem.cpp f32b3d1 

Diff: https://git.reviewboard.kde.org/r/126168/diff/


Testing
-------

Compiles. Wasn't able to reproduce the crash before but could be given during SDDM we might not use the proper kdeglobals or so.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151125/47821bef/attachment.html>


More information about the Plasma-devel mailing list