Review Request 126168: [IconItem] Don't crash on no icon theme

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126168/#review88833
-----------------------------------------------------------

Ship it!



src/declarativeimports/core/iconitem.cpp (line 137)
<https://git.reviewboard.kde.org/r/126168/#comment60872>

    const auto


- David Edmundson


On Nov. 25, 2015, 3:59 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126168/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 3:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 355577
>     http://bugs.kde.org/show_bug.cgi?id=355577
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> According to the docs theme() in KIconLoader can return null. Guard for this.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.cpp f32b3d1 
> 
> Diff: https://git.reviewboard.kde.org/r/126168/diff/
> 
> 
> Testing
> -------
> 
> Compiles. Wasn't able to reproduce the crash before but could be given during SDDM we might not use the proper kdeglobals or so.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151125/31819924/attachment-0001.html>