Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

[David Rosca]

> On Nov. 25, 2015, 2:08 p.m., Sebastian Kügler wrote:
> > src/wizard/pages/pairing.cpp, line 111
> > <https://git.reviewboard.kde.org/r/126160/diff/1/?file=418131#file418131line111>
> >
> >     The *2 seems fairly random. Can't we set the right minimum width derived from the pinNumber? Given the pin numbers display is huge, wouldn't this lead to a very large widget? Also, distinction between minimumSize and preferredSize would be more useful here.

The issue is that the size constraints are not updated when the pin number is set (not sure why). So I've changed it to explicitly set wizard's minimumSize to the wizard's sizeHint.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126160/#review88800
-----------------------------------------------------------


On Nov. 25, 2015, 5:03 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126160/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 5:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 355798
>     https://bugs.kde.org/show_bug.cgi?id=355798
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> Set the minimum window size to be twice the width of PIN label.
> 
> 
> Diffs
> -----
> 
>   src/wizard/pages/pairing.cpp 6d1eac0 
> 
> Diff: https://git.reviewboard.kde.org/r/126160/diff/
> 
> 
> Testing
> -------
> 
> The window gets resized now if there is not enough free space for PIN.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151125/90870e6f/attachment.html>