Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126160/#review88800
-----------------------------------------------------------



src/wizard/pages/pairing.cpp (line 111)
<https://git.reviewboard.kde.org/r/126160/#comment60865>

    The *2 seems fairly random. Can't we set the right minimum width derived from the pinNumber? Given the pin numbers display is huge, wouldn't this lead to a very large widget? Also, distinction between minimumSize and preferredSize would be more useful here.



src/wizard/pages/pairing.cpp (line 143)
<https://git.reviewboard.kde.org/r/126160/#comment60866>

    same as above concern.


- Sebastian Kügler


On Nov. 24, 2015, 9:36 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126160/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 9:36 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 355798
>     https://bugs.kde.org/show_bug.cgi?id=355798
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> Set the minimum window size to be twice the width of PIN label.
> 
> 
> Diffs
> -----
> 
>   src/wizard/pages/pairing.cpp 6d1eac0 
> 
> Diff: https://git.reviewboard.kde.org/r/126160/diff/
> 
> 
> Testing
> -------
> 
> The window gets resized now if there is not enough free space for PIN.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151125/b53b8bee/attachment.html>