Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

[Boudhayan Gupta]

> On Nov. 16, 2015, 10:46 p.m., Hrvoje Senjan wrote:
> > >assuming, that is, distros push out the updates together
> > 
> > don't assume this ;-) at least send a mail to kde-distro-packagers about the sideeffects if those 3 are pushed asynchronously
> 
> Boudhayan Gupta wrote:
>     'course, I'll post there as well as add a big fat notice to the kde-apps-announce posting that announces this special release of KSnapshot.
>     
>     So ship it?
> 
> David Edmundson wrote:
>     Lets email them first. Check they're ok with it, before we do it.

Haven't had any negative comments (or any comments at all) on the thread yet. Should I commit it now (and generate the KSnapshot tarballs)? The Plasma release is just days away.


- Boudhayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126091/#review88438
-----------------------------------------------------------


On Nov. 16, 2015, 10:36 p.m., Boudhayan Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126091/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 10:36 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Repository: khotkeys
> 
> 
> Description
> -------
> 
> After moving KSnapshot to Extragear I've modified it to install its own khotkeys file (which it does correctly). Spectacle already installs its own KHotkeys file, so there's no reason anymore for KHotkeys to include its own PrintScreen hotkey file.
> 
> I'll push out a special release of KSnapshot for distributions to use once the Plasma 5.5 version of KHotkeys is pushed out, so printscreen functionality won't be broken on the desktop (assuming, that is, distros push out the updates together).
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt f3bcb57 
>   data/printscreen.khotkeys e583311 
> 
> Diff: https://git.reviewboard.kde.org/r/126091/diff/
> 
> 
> Testing
> -------
> 
> Doesn't install the printscreen.khotkeys file anymore
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151123/9abe6b36/attachment.html>